-
-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow admin extension to configure admin at initialize time #7144
Allow admin extension to configure admin at initialize time #7144
Conversation
…instead of AbstractAdmin::configure
* Get a chance to configure admin before used. | ||
* | ||
* @phpstan-param AdminInterface<T> $admin | ||
*/ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
we could also add // NEXT_MAJOR: Uncomment this method
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I will uncomment this during the merge
@VincentLanglet @dmaicher if this is used to generate routes, this might lead to unexpected behaviour as Symfony will store the route in a cached file. This file will not change even if you add custom rules at runtime to alter routes. |
I don't expect people to use it like this. |
Subject
Allow admin to be configured by extensions at initialize time.
I am targeting this branch, because code is backwards compatible.
Closes #6890.
Changelog
To do