Add final for every method of abstract classes

[VincentLanglet]

Subject

I am targeting this branch, because BC.

Closes #5791. (I think)

Changelog

### Added
- `final` for method of every abstract classes.

[VincentLanglet]

I need to check if the haveToPaginate override in the Simple Pager could be removed.

[VincentLanglet]

I need to check if the haveToPaginate override in the Simple Pager could be removed.

Maybe you can help me @franmomu since you're using the Simple Pager ; do you see any differences if you remove the override of the method ?

[franmomu]

I need to check if the haveToPaginate override in the Simple Pager could be removed.

Maybe you can help me @franmomu since you're using the Simple Pager ; do you see any differences if you remove the override of the method ?

I haven't checked in a project and I guess it would be the same, but in SimplePager I guess it's implemented that way for performance reasons.

[VincentLanglet]

I haven't checked in a project and I guess it would be the same, but in SimplePager I guess it's implemented that way for performance reasons.

Since the countResults method is not doing any queries:

    public function countResults(): int
    {
        $n = ($this->getLastPage() - 1) * $this->getMaxPerPage();
        if ($this->getLastPage() === $this->getPage()) {
            return $n + $this->thresholdCount;
        }

        return $n;
    }

I don't see real perfomance improvements.

[franmomu]

When iterating results:

SonataAdminBundle/src/Datagrid/SimplePager.php

Lines 92 to 113 in 7805e4a

	public function getCurrentPageResults(): iterable
	{
	if (null !== $this->results) {
	return $this->results;
	}
	$this->results = $this->getQuery()->execute();
	$this->thresholdCount = \count($this->results);
	if (\count($this->results) > $this->getMaxPerPage()) {
	$this->haveToPaginate = true;
	if ($this->results instanceof ArrayCollection) {
	$this->results = new ArrayCollection($this->results->slice(0, $this->getMaxPerPage()));
	} else {
	$this->results = new ArrayCollection(\array_slice($this->results, 0, $this->getMaxPerPage()));
	}
	} else {
	$this->haveToPaginate = false;
	}
	return $this->results;
	}

this->haveToPaginate is set, so there is no need to even make any call, I haven't check the real performance though.

[VincentLanglet]

this->haveToPaginate is set, so there is no need to even make any call, I haven't check the real performance though.

I agree, but only a multiplication and a sum is done, so it's not significant.

[jordisala1991]

I need to check if the haveToPaginate override in the Simple Pager could be removed.

IMO we should not mark it final if the simple pager overrides it, have you tried performance implications of it?

[VincentLanglet]

IMO we should not mark it final if the simple pager overrides it, have you tried performance implications of it?

Previously it was

    public function haveToPaginate()
    {
        return $this->haveToPaginate || $this->getPage() > 1;
    }

Now it's

        $n = ($this->getLastPage() - 1) * $this->getMaxPerPage();
        if ($this->getLastPage() === $this->getPage()) {
            return $n + $this->thresholdCount;
        }

        return $n > $this->getMaxPerPage();

It only cost a multiplication ; there is no impact.

[VincentLanglet]

Please review @sonata-project/contributors

[jordisala1991]

Thank you @VincentLanglet