Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix matching filter links in search results #7093

Merged
merged 1 commit into from
Apr 19, 2021
Merged

Fix matching filter links in search results #7093

merged 1 commit into from
Apr 19, 2021

Conversation

phansys
Copy link
Member

@phansys phansys commented Apr 19, 2021

Subject

Fix matching filters links in search results

I am targeting this branch, because these changes respect BC.

Related to #7005.

Changelog

### Fixed
- URLs generated at global search results for the list filtering, which were missing the `value` dimension;
- Layout for the filter links generated at global search results.

@phansys phansys added the patch label Apr 19, 2021
@phansys phansys marked this pull request as ready for review April 19, 2021 12:47
@phansys phansys requested a review from a team April 19, 2021 12:47
@phansys phansys changed the title Fix matching filters links in search results Fix matching filter links in search results Apr 19, 2021
@phansys phansys requested a review from a team April 19, 2021 12:53
franmomu
franmomu approved these changes Apr 19, 2021
View reviewed changes
Copy link
Member

@franmomu franmomu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we have to be pay attention to the layout.css when merging

@phansys phansys merged commit 01677b2 into sonata-project:3.x Apr 19, 2021
@phansys phansys deleted the matching_filters branch April 19, 2021 21:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@VincentLanglet VincentLanglet VincentLanglet approved these changes

@franmomu franmomu franmomu approved these changes

Assignees
No one assigned
Labels
patch
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@phansys @franmomu @VincentLanglet