Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow AbstractAdmin::getListMode() to return the default value if the request hasn't a session #7080

Merged
merged 1 commit into from
Apr 17, 2021
Merged

Allow AbstractAdmin::getListMode() to return the default value if the request hasn't a session #7080

merged 1 commit into from
Apr 17, 2021

Conversation

phansys
Copy link
Member

@phansys phansys commented Apr 17, 2021

Subject

Allow AbstractAdmin::getListMode() to return the default value if the request hasn't a session.

I am targeting this branch, because this change respects BC.

Triggered by #7033 (comment).

Changelog

### Fixed
- Using a non existing `Session` instance from the `Request` object at `AbstractAdmin::getListMode()`.

@phansys phansys added the patch label Apr 17, 2021
@phansys phansys requested a review from a team April 17, 2021 12:18
@phansys phansys marked this pull request as ready for review April 17, 2021 12:23
@phansys phansys requested a review from jordisala1991 April 17, 2021 12:24
@VincentLanglet VincentLanglet requested a review from a team April 17, 2021 12:58
@phansys phansys mentioned this pull request Apr 17, 2021
Merged
1 task
@jordisala1991 jordisala1991 merged commit 3a5b5d3 into sonata-project:3.x Apr 17, 2021
@jordisala1991
Copy link
Member

Thank you @phansys

@phansys phansys deleted the admin_get_list_mode branch April 17, 2021 13:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@VincentLanglet VincentLanglet VincentLanglet approved these changes

@jordisala1991 jordisala1991 jordisala1991 approved these changes

Assignees
No one assigned
Labels
patch
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@phansys @jordisala1991 @VincentLanglet