Move template param of the ModelManager to the class #7066
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
VincentLanglet
force-pushed
the
modelManagerTemplate
branch
5 times, most recently
from
30bc9f9 to
5636913
Compare
VincentLanglet
force-pushed
the
modelManagerTemplate
branch
from
5636913 to
82121f7
Compare
phansys
approved these changes
Apr 14, 2021
core23
approved these changes
Apr 15, 2021
jordisala1991
approved these changes
Apr 15, 2021
|
Thank you @VincentLanglet |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Subject
I am targeting this branch, because BC.
@franmomu You proposed this change #6721, and I didn't fully understand if it was a good change or not. Now I think I agree with your proposal.
If the modelManager is generic,
ModelManager<object>orModelManager<T>could be used.If the modelManager works only for some objects, like https://github.com/sonata-project/SonataAdminBundle/blob/3.x/tests/App/Model/ModelManager.php#L22, it could be
ModelManager<Foo>.It could fixed https://github.com/sonata-project/SonataAdminBundle/blob/master/tests/App/Model/ModelManager.php#L56-L60
See https://phpstan.org/r/ab8c0e82-a65c-4b98-9662-18e07a73ce07 Vs https://phpstan.org/r/adc525ad-dadf-4912-af8e-7087ac6b1344
Changelog