Leverage AdminInterface::getIdParameter() and AdminInterface::getUrlSafeIdentifier()
#7055
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Removes the hardcode id parameter in favor of AdminInterface::getIdParameter() method. And recommend in docs the use of AdminInterface::generateObjectUrl() method.
Instead of AdminInterface::id() when generating URLs.
franmomu
force-pushed
the
do_not_hardcode_id
branch
from
45f3b61 to
cc9fd30
Compare
| {% elseif admin.hasAccess('show', object) and admin.hasRoute('show') %} | ||
| <a href="{{ admin.generateUrl('show', {'id' : object|sonata_urlsafeid(admin) }) }}">{{ meta.title|u.truncate(40) }}</a> |
There was a problem hiding this comment.
If we cannot deprecate sonata_urlsafeid (#6963 (comment)),
Can we at least deprecate the param admin of the sonata_urlsafeid filter ?
(But the best would be to deprecate sonata_urlsafeid to promote passing the admin in the view and using generateObjectUrl... ; and if a bundle cannot do without it, it will implement his own extension)
phansys
approved these changes
Apr 13, 2021
VincentLanglet
approved these changes
Apr 13, 2021
| {{ mosaic_content }} | ||
| </a> | ||
| {% elseif admin.hasAccess('show', object) and admin.hasRoute('show') %} | ||
| <a class="mosaic-inner-link" | ||
| href="{{ admin.generateUrl('show', {'id' : object|sonata_urlsafeid(admin) }) }}"> | ||
| href="{{ admin.generateUrl('show', {(admin.idParameter) : object|sonata_urlsafeid(admin) }) }}"> |
There was a problem hiding this comment.
this can be changed to not use the filter right?
This was referenced Apr 14, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Subject
As suggested by @phansys for
SonataPageBundle, this PR removes the hardcodeidparameter in favor ofAdminInterface::getIdParameter()method.Also replaces the use of
AdminInterface::id()when generating URLs byAdminInterface::getUrlSafeIdentifier().I am targeting this branch, because these changes are BC.
Changelog