Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update to AdminLTE 2.4.15 #7032

Merged
merged 1 commit into from
Apr 10, 2021
Merged

Update to AdminLTE 2.4.15 #7032

merged 1 commit into from
Apr 10, 2021

Conversation

core23
Copy link
Member

@core23 core23 commented Apr 10, 2021

Subject

I am targeting this branch, because this is BC.

Closes #7031

Changelog

### Changed
- Update to AdminLTE 2.4.15

@core23 core23 requested a review from a team April 10, 2021 09:56
@core23 core23 force-pushed the admin-lte-2-update branch from 44a0683 to 20a2faa Compare April 10, 2021 09:58
jordisala1991
jordisala1991 previously approved these changes Apr 10, 2021
View reviewed changes
Copy link
Member

@jordisala1991 jordisala1991 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would be really nice to atleast have this throug package.json for the final 4.0 (even without upgrading it)

VincentLanglet
VincentLanglet reviewed Apr 10, 2021
View reviewed changes
Copy link
Member

@VincentLanglet VincentLanglet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should be able to update to 2.4.18 https://github.com/ColorlibHQ/AdminLTE/releases/tag/v2.4.18 isn't it ?

src/DependencyInjection/Configuration.php Outdated Show resolved Hide resolved
@core23
Copy link
Member Author

core23 commented Apr 10, 2021

Would be really nice to atleast have this throug package.json for the final 4.0 (even without upgrading it)

We could load this via composer: https://github.com/ColorlibHQ/AdminLTE/blob/master/composer.json

@jordisala1991
Copy link
Member

Would be really nice to atleast have this throug package.json for the final 4.0 (even without upgrading it)

We could load this via composer: https://github.com/ColorlibHQ/AdminLTE/blob/master/composer.json

ugh, not sure about that, this is a css + js dependency, not a php one

@core23 core23 force-pushed the admin-lte-2-update branch from 20a2faa to 3cbbf95 Compare April 10, 2021 13:05
@core23 core23 force-pushed the admin-lte-2-update branch from 3cbbf95 to a61c239 Compare April 10, 2021 13:07
@phansys phansys requested a review from jordisala1991 April 10, 2021 14:14
@OskarStark OskarStark merged commit f15b39a into sonata-project:3.x Apr 10, 2021
@core23 core23 deleted the admin-lte-2-update branch April 10, 2021 18:11
@jordisala1991 jordisala1991 mentioned this pull request Apr 18, 2021
Merged
@gremo gremo mentioned this pull request Apr 30, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@VincentLanglet VincentLanglet VincentLanglet approved these changes

@phansys phansys phansys approved these changes

@OskarStark OskarStark OskarStark approved these changes

@jordisala1991 jordisala1991 Awaiting requested review from jordisala1991

Assignees
No one assigned
Labels
minor
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Update AdminLTE 2
5 participants
@core23 @jordisala1991 @OskarStark @phansys @VincentLanglet