Deprecate more service aliases

[franmomu]

Subject

It should have been included in #7001

I am targeting this branch, because these changes are BC.

Changelog

### Deprecated
- Deprecated `Sonata\AdminBundle\Admin\AdminHelper` service alias.
- Deprecated `Sonata\AdminBundle\SonataConfiguration` service alias.

[VincentLanglet]

How do you know that these one are not supposed to be in the public API ? But Pool or AdminObjectAclManipulator yes ?
I read #7000 but I dont understand.

[franmomu]

How do you know that these one are not supposed to be in the public API ? But Pool or AdminObjectAclManipulator yes ?
I read #7000 but I dont understand.

I meant this part:

and aliases needed in case we use Service Subscribers (like CRUDController in 4.x).

In CRUDController we have:

SonataAdminBundle/src/Controller/CRUDController.php

Lines 74 to 88 in c1b3acf

	public static function getSubscribedServices(): array
	{
	return [
	'sonata.admin.pool' => Pool::class,
	'sonata.admin.breadcrumbs_builder' => BreadcrumbsBuilderInterface::class,
	'sonata.admin.audit.manager' => AuditManagerInterface::class,
	'sonata.admin.object.manipulator.acl.admin' => AdminObjectAclManipulator::class,
	'sonata.exporter.exporter' => '?'.Exporter::class,
	'sonata.admin.admin_exporter' => '?'.AdminExporter::class,
	'sonata.admin.security.acl_user_manager' => '?'.AdminAclUserManagerInterface::class,
	'logger' => '?'.LoggerInterface::class,
	'translator' => TranslatorInterface::class,
	] + parent::getSubscribedServices();
	}

The way it works is because it fetches the services that will be in the container from there, so those are the ones I was leaving (apart from the interfaces that I don't know if they are used).

Looking at the documentation we can maybe use https://symfony.com/doc/4.4/service_container/service_subscribers_locators.html#aliased-services and configure it through tags, I'll give it a try and we won't need anyone anymore I guess.

[franmomu]

I haven't tried too much, but looks like using tags, you have to define also parent tags (the ones from AbstractController), that makes sense with the documentation: https://symfony.com/doc/4.4/service_container/service_subscribers_locators.html#including-services

When extending a class that also implements ServiceSubscriberInterface, it’s your responsibility to call the parent when overriding the method. This typically happens when extending AbstractController

So I think it's better if we leave it as it is.

[jordisala1991]

Thank you @franmomu