Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove inline validator service #6998

Merged
merged 2 commits into from
Apr 1, 2021

Conversation

franmomu
Copy link
Member

@franmomu franmomu commented Mar 31, 2021

Subject

I'm not completely sure about this because I wasn't fully aware of the deprecations made with the validation methods, so if this is not ok, feel free to close it.

I've removed the docs since looks like all methods listed in the docs are deprecated.

Ref: #6963

I am targeting this branch, because these changes are BC.

Changelog

### Deprecated
- Deprecated `sonata.admin.validator.inline` service.

@franmomu franmomu added the minor label Mar 31, 2021
@franmomu franmomu requested a review from a team April 1, 2021 06:14
@VincentLanglet VincentLanglet merged commit fd1ed39 into sonata-project:3.x Apr 1, 2021
@VincentLanglet
Copy link
Member

Thanks @franmomu

@franmomu franmomu deleted the remove_inline_validator branch April 1, 2021 08:22
@franmomu franmomu mentioned this pull request Apr 1, 2021
7 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants