Set "or_group" filter option at SearchHandler::search()
#6992
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
composer.json
Outdated
| @@ -69,6 +69,7 @@ | |||
| "doctrine/doctrine-bundle": ">=3", | |||
| "sonata-project/core-bundle": "<3.20", | |||
| "sonata-project/doctrine-extensions": "<1.8", | |||
| "sonata-project/doctrine-orm-admin-bundle": "<3.32", | |||
There was a problem hiding this comment.
adding a conflict here does not seem right, is it needed to make it work?
There was a problem hiding this comment.
Versions previous to sonata-project/doctrine-orm-admin-bundle 3.32 haven't the fix.
Actually, the fix is provided by that package.
There was a problem hiding this comment.
Then, to get the fix you just have to update that package, not this one, right? I mean, we do not conflict on the orm-bundle when we fix something here
There was a problem hiding this comment.
The commit message and the PR description were also updated.
jordisala1991
approved these changes
Mar 30, 2021
phansys
changed the title
SearchHandler::search()
VincentLanglet
approved these changes
Mar 30, 2021
|
Thanks @phansys |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Subject
Set "or_group" filter option at
SearchHandler::search()I am targeting this branch, because this change respects BC.
Related to #2850, #3368, #5569, sonata-project/SonataDoctrineORMAdminBundle#1373.
Changelog