Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow null as return type for TypeGuesserInterface #6987

Merged
merged 1 commit into from
Mar 31, 2021
Merged

Allow null as return type for TypeGuesserInterface #6987

merged 1 commit into from
Mar 31, 2021

Conversation

VincentLanglet
Copy link
Member

Subject

I am targeting this branch, because BC.

The previous TypeGuesserInterface::guessType() could return null.
And for example, the TypeGuesserChain can return null if there is no guesser.

Changelog

### Fixed
- Allow `TypeGuesserInterface::guess()` to return `null`

@VincentLanglet VincentLanglet requested a review from a team March 29, 2021 17:36
@phansys phansys requested a review from a team March 29, 2021 19:21
@VincentLanglet VincentLanglet merged commit d17d6bd into sonata-project:3.x Mar 31, 2021
@VincentLanglet VincentLanglet deleted the fixReturnType branch March 31, 2021 13:45
@VincentLanglet VincentLanglet mentioned this pull request Apr 2, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@phansys phansys phansys approved these changes

Assignees
No one assigned
Labels
patch
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@VincentLanglet @phansys