Add tag for audit readers #6983
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
VincentLanglet
previously approved these changes
Mar 29, 2021
phansys
requested changes
Mar 29, 2021
src/DependencyInjection/Compiler/AddAuditReadersCompilerPass.php
Outdated
Show resolved
Hide resolved
franmomu
force-pushed
the
create_audit_manager_tag
branch
from
6dd8162 to
891ba09
Compare
Audit readers MUST be tagged with this tag so we can use a service locator instead of injecting the whole container in the next major version.
franmomu
force-pushed
the
create_audit_manager_tag
branch
from
891ba09 to
521de51
Compare
VincentLanglet
approved these changes
Mar 29, 2021
phansys
approved these changes
Mar 29, 2021
|
Thank you @franmomu! |
franmomu
added a commit
to franmomu/SonataDoctrineORMAdminBundle
that referenced
this pull request
Mar 30, 2021
This tag was introduced in sonata-project/SonataAdminBundle#6983
VincentLanglet
pushed a commit
to sonata-project/SonataDoctrineORMAdminBundle
that referenced
this pull request
Mar 30, 2021
This tag was introduced in sonata-project/SonataAdminBundle#6983
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Subject
Audit readers MUST be tagged with this tag so we can use a service locator instead of injecting the whole container in the next major version.
Ref: #6963
I am targeting this branch, because these changes are BC.
Changelog