Deprecate not registering filters #6976
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
franmomu
force-pushed
the
prepare_service_locator_filter
branch
2 times, most recently
from
e05de1a to
0956cfd
Compare
phansys
previously approved these changes
Mar 28, 2021
| @@ -13,9 +13,13 @@ | |||
|
|
|||
| namespace Sonata\AdminBundle\DependencyInjection\Compiler; | |||
|
|
|||
| use Sonata\AdminBundle\Filter\FilterInterface; | |||
| use Symfony\Component\DependencyInjection\Compiler\CompilerPassInterface; | |||
| use Symfony\Component\DependencyInjection\ContainerBuilder; | |||
|
|
|||
There was a problem hiding this comment.
This blank line should be removed
There was a problem hiding this comment.
It is php-cs-fixer who adds that line.
| use Sonata\AdminBundle\Filter\FilterFactoryInterface; | ||
| use Sonata\AdminBundle\Tests\Fixtures\Filter\BarFilter; | ||
| use Sonata\AdminBundle\Tests\Fixtures\Filter\FooFilter; | ||
| use Symfony\Bridge\PhpUnit\ExpectDeprecationTrait; | ||
| use Symfony\Component\DependencyInjection\ContainerBuilder; | ||
| use Symfony\Component\DependencyInjection\Definition; | ||
|
|
VincentLanglet
previously approved these changes
Mar 28, 2021
| { | ||
| } | ||
|
|
||
| public function apply($query, $value): void |
There was a problem hiding this comment.
Next_major, add typehint ?
These changes force the user to register filters as services so in next major version a service locator could be used instead of the complete container.
franmomu
force-pushed
the
prepare_service_locator_filter
branch
from
0956cfd to
7532bd0
Compare
VincentLanglet
approved these changes
Mar 28, 2021
jordisala1991
approved these changes
Mar 28, 2021
|
Thank you @franmomu |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Subject
These changes force the user to register filters as services so in next major version a service locator could be used instead of the complete container.
I am targeting this branch, because these changes are BC.
Changelog