-
-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use camel case for arguments and variables at CRUDController::historyCompareRevisionsAction()
#6913
Conversation
Tests are passing, but I think the exit code is not 0 given the limit configured for the deprecation messages:
|
I think #6911 could fix your issue |
CRUDController::historyCompareRevisionsAction()
CRUDController::historyCompareRevisionsAction()
454a551
to
9eeda0a
Compare
@@ -47,7 +47,7 @@ public function build(AdminInterface $admin, RouteCollection $collection) | |||
if ($this->manager->hasReader($admin->getClass())) { | |||
$collection->add('history', sprintf('%s/history', $admin->getRouterIdParameter())); | |||
$collection->add('history_view_revision', sprintf('%s/history/{revision}/view', $admin->getRouterIdParameter())); | |||
$collection->add('history_compare_revisions', sprintf('%s/history/{base_revision}/{compare_revision}/compare', $admin->getRouterIdParameter())); | |||
$collection->add('history_compare_revisions', sprintf('%s/history/{baseRevision}/{compareRevision}/compare', $admin->getRouterIdParameter())); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not sure if you should change the route in a stable release
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'll try to check how could we deal with this.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@core23, I added a BC layer for those cases where the param names are explicitly used.
752b437
to
301eefc
Compare
@@ -866,38 +866,62 @@ public function historyCompareRevisionsAction($id = null, $base_revision = null, | |||
|
|||
$reader = $manager->getReader($this->admin->getClass()); | |||
|
|||
// NEXT_MAJOR: Remove this condition. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you provide a test that verifies this hack?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done.
…yCompareRevisionsAction()`
Thanks @phansys |
Subject
Use camel case for arguments and variables at
CRUDController::historyCompareRevisionsAction()
.I am targeting this branch, because these changes respect BC.
Changelog