Add generic information for child admins #6882
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
core23
commented
Feb 20, 2021
| @@ -75,7 +75,7 @@ public function configureRoutes(AdminInterface $admin, RouteCollection $collecti | |||
| * @return void | |||
| * | |||
| * @phpstan-param AdminInterface<T> $admin | |||
| * @phpstan-param AdminInterface<T>|null $childAdmin | |||
| * @phpstan-param AdminInterface<object>|null $childAdmin | |||
There was a problem hiding this comment.
The admin and child admin can mange different types, so object is more accurate here.
VincentLanglet
approved these changes
Feb 20, 2021
franmomu
approved these changes
Feb 21, 2021
|
thanks @core23! (now I can remove all those ignored errors 😬 ) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Subject
There are some method signatures that does not specify the generic type of the
AdminInterface. Some types are wrong.From the API perspective, you can not determine the type of the child admin. It could be of any type.
I am targeting this branch, because this is BC.
Changelog