Remove param from ProxyQueryInterface::execute #6827
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
VincentLanglet
force-pushed
the
execute
branch
from
99cd3f6 to
fec084f
Compare
greg0ire
approved these changes
Jan 31, 2021
franmomu
approved these changes
Jan 31, 2021
| @@ -128,6 +128,7 @@ public function getResults($hydrationMode = null) | |||
| return $this->results; | |||
| } | |||
|
|
|||
| // @phpstan-ignore-next-line | |||
| $this->results = $this->getQuery()->execute([], $hydrationMode); | |||
There was a problem hiding this comment.
I think a NEXT_MAJOR version should be added to remove those arguments.
There was a problem hiding this comment.
The method is already deprecated and removed in the next major.
VincentLanglet
added a commit
that referenced
this pull request
Feb 9, 2021
* Remove param from ProxyQueryInterface::execute (#6827) * Explicitly require some packages (#6834) * fix phpstan error (#6841) * fix after merge Co-authored-by: Vincent Langlet <[email protected]> Co-authored-by: Fran Moreno <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Subject
I am targeting this branch, because BC.
Closes #6260.
Changelog