Fixed choice_list for ModelType #682
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| ); | ||
|
|
||
| if ($previousValue instanceof ChoiceListInterface | ||
| && count($choices = $previousValue->getChoices())) { |
There was a problem hiding this comment.
should it go in 1 line instead?
There was a problem hiding this comment.
according to phpcs this is CS compliant now.
ft-1408
pushed a commit
to intexsys/SonataAdminBundle
that referenced
this pull request
Sep 17, 2021
Fixed German and Ukrainian translations
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes a fatal error in the
getDefaultOptions()method of theModelType. The choice_list closure returned only aModelChoiceListwhen the$previousValuewas null, but this is an instance of aChoiceListInterfacenow - with an emptychoicesarray.