Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix display of select filter list with no choice #6818

Merged
merged 1 commit into from
Jan 29, 2021
Merged

Fix display of select filter list with no choice #6818

merged 1 commit into from
Jan 29, 2021

Conversation

VincentLanglet
Copy link
Member

Subject

I am targeting this branch, because bugfix.

Changelog

### Fixed
- Stop displaying the filter dropdown with no usable filters

@VincentLanglet VincentLanglet requested a review from a team January 28, 2021 16:04
@VincentLanglet VincentLanglet merged commit 5b64798 into sonata-project:3.x Jan 29, 2021
@VincentLanglet VincentLanglet deleted the filters branch January 29, 2021 08:27
@kirya-dev
Copy link
Contributor

Great!
But this template has same checks: admin.datagrid.hasDisplayableFilters
Its can be refactored?

@kirya-dev
Copy link
Contributor

Replace filter closures into Datagrid?

@kirya-dev
Copy link
Contributor

Add following methods:

Datagrid::getCanBeDisplayedFilters()
Filter::isDisplayed()
Filter::canBeDisaplayed()

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dmaicher dmaicher dmaicher approved these changes

@franmomu franmomu franmomu approved these changes

Assignees
No one assigned
Labels
patch
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@VincentLanglet @kirya-dev @franmomu @dmaicher