-
-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use propertyAccessor for BaseFieldDescription::getFieldValue #6798
Use propertyAccessor for BaseFieldDescription::getFieldValue #6798
Conversation
e754451
to
8778aeb
Compare
8778aeb
to
dbf9e0f
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do we need property access as composer dep?
We already have |
If we use the SonataAdminBundle/src/Admin/BaseFieldDescription.php Lines 398 to 400 in dbf9e0f
I think (without trying it) all code below those lines can be replace using |
If I replace everything, I lost the |
This PR introduces a BC break since |
@franmomu Do you have a use case ? |
Apparently it is always like: https://github.com/sonata-project/SonataDoctrineORMAdminBundle/blob/b656ccab02db9abf397e04a69ca0e2bda9bfd455/src/Builder/ListBuilder.php#L127 The problem I guess is that before, |
I made #6855 |
It will solve #6795 and we will rely on propertyAccessor implementation instead of a custom one.
We're loosing the parameters option but I'm not sure it's used and it's solvable by using a custom template instead.
Changelog