Move TemplateRegistryInterface::TYPE_* constants #6752
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wbloszyk
previously approved these changes
Jan 8, 2021
|
@sonata-project/contributors Can we merge it? |
VincentLanglet
requested changes
Jan 8, 2021
There was a problem hiding this comment.
You need to update the doc: for instance https://github.com/sonata-project/SonataAdminBundle/blob/29bbbb0da7270e112546e043021211bebdab9fff/docs/reference/action_list.rst
franmomu
force-pushed
the
move_constants_field_description
branch
from
eb6e045 to
b9936be
Compare
They have been moved to FieldDescriptionInterface since they are the values of FieldDescriptionInterface::getType.
franmomu
force-pushed
the
move_constants_field_description
branch
from
b9936be to
4c2a846
Compare
VincentLanglet
approved these changes
Jan 8, 2021
wbloszyk
approved these changes
Jan 8, 2021
|
Thank you @franmomu |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Subject
They have been moved to
FieldDescriptionInterfacesince they are the values ofFieldDescriptionInterface::getType().In the future, maybe we can create classes for each type and have some configuration and logic in there instead of having it in the associated template.
I am targeting this branch, because these changes are BC.
Closes #6749.
Changelog