Deprecate CRUDController::configure() method #6751
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2 tasks
VincentLanglet
previously approved these changes
Jan 7, 2021
dmaicher
reviewed
Jan 7, 2021
| public function setContainer(?ContainerInterface $container = null) | ||
| { | ||
| $this->container = $container; | ||
|
|
||
| $this->configure(); | ||
| $this->configure('sonata_deprecation_mute'); |
There was a problem hiding this comment.
why not call the new configureAdmin method here? then no need to mute the deprecation, or?
There was a problem hiding this comment.
In case someone override $this->configure maybe ?
There was a problem hiding this comment.
ah maybe people have overwritten the configure method 😢 forget it.
dmaicher
previously approved these changes
Jan 7, 2021
phansys
requested changes
Jan 7, 2021
franmomu
force-pushed
the
configure_method
branch
from
7e3276c to
433fdd2
Compare
phansys
reviewed
Jan 8, 2021
phansys
previously approved these changes
Jan 8, 2021
|
Could you please rebase your PR and fix merge conflicts? |
In next major version, the controller will be configured with an external call from an event listener instead of using setContainer method.
franmomu
force-pushed
the
configure_method
branch
from
433fdd2 to
23627f1
Compare
phansys
approved these changes
Jan 8, 2021
VincentLanglet
approved these changes
Jan 8, 2021
|
Thanks @franmomu |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Subject
In next major version, the controller will be configured with an external call from an event listener instead of using setContainer method.
For more context: #6615
I am targeting this branch, because this is BC.
Changelog