Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add removeTab method #6746

Merged
merged 1 commit into from
Jan 8, 2021
Merged

Add removeTab method #6746

merged 1 commit into from
Jan 8, 2021

Conversation

VincentLanglet
Copy link
Member

@VincentLanglet VincentLanglet commented Jan 5, 2021 •
edited
Loading

Subject

BC

Changelog

### Added
- `Added BaseGroupMapper::removeGroup()`
- `Added BaseGroupMapper::removeTab()`

@VincentLanglet VincentLanglet force-pushed the addRemoveTab branch 2 times, most recently from 4b3a6a5 to e7e4b9f Compare January 5, 2021 16:26
@VincentLanglet VincentLanglet marked this pull request as ready for review January 5, 2021 16:31
@VincentLanglet VincentLanglet requested a review from a team January 5, 2021 16:31
OskarStark
OskarStark reviewed Jan 5, 2021
View reviewed changes
tests/Form/FormMapperTest.php
@@ -494,6 +494,16 @@ public function testGroupRemovingWithTabAndWithTabRemoving(): void
$this->assertSame([], $this->admin->getFormTabs());
}

public function testTabRemoving(): void
{
$this->formMapper->tab('mytab')->with('foobar');
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Shall we assert first that it is set?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tab/with methods are already tested in another test

@VincentLanglet VincentLanglet requested a review from a team January 5, 2021 18:29
@VincentLanglet VincentLanglet requested review from OskarStark and a team January 6, 2021 13:55
@OskarStark OskarStark merged commit dc1fa9a into sonata-project:3.x Jan 8, 2021
@VincentLanglet VincentLanglet deleted the addRemoveTab branch March 27, 2021 22:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@core23 core23 core23 approved these changes

@OskarStark OskarStark Awaiting requested review from OskarStark

Assignees
No one assigned
Labels
minor
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@VincentLanglet @OskarStark @core23