Deprecate DateOperatorType::TYPE_NULL and TYPE_NOT_NULL #6734
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
OskarStark
previously approved these changes
Jan 5, 2021
|
Could you please rebase your PR and fix merge conflicts? |
VincentLanglet
force-pushed
the
deprecateNull
branch
from
41f5158 to
4e1b6fa
Compare
|
Please take a look @sonata-project/contributors |
phansys
previously approved these changes
Jan 11, 2021
|
Could you please rebase your PR and fix merge conflicts? |
VincentLanglet
force-pushed
the
deprecateNull
branch
from
4e1b6fa to
54c8055
Compare
phansys
approved these changes
Jan 11, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Subject
I recommend deprecating these two constants.
The UX is weird because you can still provide a value when you selected these types.
I recommend instead using a specific filter for null values like the
NullFilterof DoctrineORMAdminBundle.I am targeting this branch, because BC.
Changelog