Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix - Variable "admin" does not exist. #6727

Merged
merged 2 commits into from
Jan 2, 2021
Merged

Fix - Variable "admin" does not exist. #6727

merged 2 commits into from
Jan 2, 2021

Conversation

ggabrovski
Copy link
Contributor

@ggabrovski ggabrovski commented Jan 2, 2021

Subject

After updating to 3.84 I found some Twig runtime error related to missing "admin" variable. Probably one extra check will fix the issue or someone with more experience can suggest better solution.

I am targeting this branch, because of BC.

Changelog

### Fixed
Variable "admin" does not exist in `CRUD/Association/edit_many_script.html.twig`

@VincentLanglet
Copy link
Member

VincentLanglet commented Jan 2, 2021

Hi @ggabrovski,

{% if admin.label is not empty %} should be changed to {% if associationadmin.label is not empty %} ; can you update the PR ?

@VincentLanglet VincentLanglet merged commit 2ad75fe into sonata-project:3.x Jan 2, 2021
@VincentLanglet
Copy link
Member

Thanks !

@ggabrovski
Copy link
Contributor Author

It was in #6614
src/Resources/views/CRUD/Association/edit_many_script.html.twig

I change it to associationadmin.label

VincentLanglet, Thank you very much for the support

@ggabrovski ggabrovski deleted the fix_twig_admin_not_exist branch January 2, 2021 21:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants