Fix form label in next major #6718
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
VincentLanglet
force-pushed
the
formLabel
branch
from
459a98c to
f0b412a
Compare
OskarStark
approved these changes
Dec 21, 2020
wbloszyk
approved these changes
Dec 31, 2020
core23
approved these changes
Dec 31, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pedantic.
Currently, with
and the label underscore strategy.
The show label is
show.label_foo_bar_baz.The form label is
form.label_foo__bar_baz.The issue is that for the form,
.are forbidden and replaced by__.But we should use the given name for the label, instead of the new sanitized one.
This will add consistency in next major. I don't fix it in 3.x to avoid people to rewrite every label.