Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove public access for getFieldValue #6716

Merged
merged 1 commit into from
Jan 1, 2021
Merged

Remove public access for getFieldValue #6716

merged 1 commit into from
Jan 1, 2021

Conversation

VincentLanglet
Copy link
Member

Subject

When working on an issue of SonataDoctrineORMAdminBundle, I discovered that getFieldValue was in the interface, but to me it's a method implemented in BaseFieldDescription to help the getValue implementation.

So I propose to restrict the visibility of this method.

I am targeting this branch, because BC.

Changelog

### Deprecated
- `FieldDescriptionInterface::getFieldValue()`

@VincentLanglet VincentLanglet requested a review from a team December 19, 2020 18:38
core23
core23 previously approved these changes Dec 20, 2020
View reviewed changes
@VincentLanglet VincentLanglet requested a review from a team December 20, 2020 19:52
@SonataCI
Copy link
Collaborator

Could you please rebase your PR and fix merge conflicts?

@VincentLanglet VincentLanglet added this to the 4.0 milestone Dec 23, 2020
@SonataCI
Copy link
Collaborator

Could you please rebase your PR and fix merge conflicts?

wbloszyk
wbloszyk approved these changes Dec 31, 2020
View reviewed changes
Copy link
Member

@wbloszyk wbloszyk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It is fine when you think about replace getFieldValue by getChildValue. First is in Admin, second in DoctrineORMAdmin. It is correct if we do not need these methods public.

@VincentLanglet VincentLanglet merged commit 9dfe863 into sonata-project:3.x Jan 1, 2021
@VincentLanglet VincentLanglet deleted the fieldValue branch January 1, 2021 13:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@core23 core23 core23 approved these changes

@wbloszyk wbloszyk wbloszyk approved these changes

Assignees
No one assigned
Labels
minor
Projects
None yet
Milestone
4.0
Development

Successfully merging this pull request may close these issues.
5 participants
@VincentLanglet @SonataCI @wbloszyk @core23 @OskarStark