Add RouteCollectionInterface #6699
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This interface was added in 4.x branch, this commit imports it removing type and return declarations to make it compatible with RouteCollection which implements this interface. In sonata 4 AbstractAdmin::configureRoutes() method receives a RouteCollectionInterface, importing this interface in 3.x would allow users to update their code and define this method as in 4 easing the upgrading process.
VincentLanglet
previously approved these changes
Dec 11, 2020
|
Could you please rebase your PR and fix merge conflicts? |
wbloszyk
previously approved these changes
Dec 23, 2020
VincentLanglet
dismissed stale reviews from wbloszyk and themself
via
75fb405
VincentLanglet
approved these changes
Dec 24, 2020
|
Thanks @franmomu |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Subject
Related #6698
This interface was added in 4.x branch, this commit imports it removing type and return declarations to make it compatible with
RouteCollectionwhich implements this interface.In sonata 4
AbstractAdmin::configureRoutes()method receives aRouteCollectionInterface, importing this interface in 3.x would allow users to update their code and define this method as in 4, easing the upgrading process.This would only work for users with PHP >= 7.4 because contravariance was fully support since that version, to me this is fine, but we could remove
AbstractAdmin::configureRoutes()andAdminExtensionInterface::configureRoutes()methods and add somemethod_existschecks and reintroduce these methods in4.xbranch.I am targeting this branch, because these changes are BC.
Closes #6698.
Changelog