Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disable sorting for an associated_property callable #6675

Merged
merged 1 commit into from
Dec 9, 2020

Conversation

franmomu
Copy link
Member

@franmomu franmomu commented Dec 8, 2020

Subject

Related to #6649

I am targeting this branch, because this is BC.

Closes #6649.

Changelog

### Fixed
- Fixed disallowing sorting in a field defined with a closure in `associated_property`.

@franmomu franmomu added the patch label Dec 8, 2020
@franmomu franmomu requested a review from a team December 8, 2020 20:03
@greg0ire greg0ire merged commit 03a3799 into sonata-project:3.x Dec 9, 2020
@greg0ire
Copy link
Contributor

greg0ire commented Dec 9, 2020

Squashed, I added an explanation in the commit message. Thanks @franmomu !

@franmomu franmomu deleted the closure_not_sortable branch December 9, 2020 09:58
@franmomu
Copy link
Member Author

franmomu commented Dec 9, 2020

Squashed, I added an explanation in the commit message. Thanks @franmomu !

Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Object of class Closure could not be converted to string
3 participants