Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add generic for CRUDController #6643

Merged
merged 2 commits into from
Dec 4, 2020

Conversation

VincentLanglet
Copy link
Member

Subject

I am targeting this branch, because BC

Changelog

### Added
- Added generics to `CRUDController`

@VincentLanglet VincentLanglet marked this pull request as draft December 3, 2020 15:42
@VincentLanglet VincentLanglet force-pushed the Crud branch 2 times, most recently from 1fb794f to b1752bc Compare December 3, 2020 16:26
@VincentLanglet
Copy link
Member Author

@sonata-project/contributors There is a weird issue with phpstan, I fixed it with the second commit

@VincentLanglet VincentLanglet merged commit c30d61e into sonata-project:3.x Dec 4, 2020
@VincentLanglet VincentLanglet deleted the Crud branch December 4, 2020 11:17
@franmomu franmomu added the minor label Dec 5, 2020
@VincentLanglet VincentLanglet restored the Crud branch December 6, 2020 11:23
@VincentLanglet VincentLanglet deleted the Crud branch March 27, 2021 22:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants