Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix AdminInterface Inheritance #6597

Merged
merged 1 commit into from
Nov 17, 2020

Conversation

VincentLanglet
Copy link
Member

Subject

When working on merge 3.x into master, I had to make this change because the signature wasn't compatible.
The issue didn't appear on 3.x because we were just using @method.

I am targeting this branch, because I consider this as a bug fix.

But I have some questions (cc @wbloszyk)

  • Shouldn't MutableTemplateRegistryAwareInterface extends TemplateRegistryAwareInterface this way ?
interface MutableTemplateRegistryAwareInterface extends TemplateRegistryAwareInterface
{
    /**
     * @return MutableTemplateRegistryInterface
     */
    public function getTemplateRegistry(): TemplateRegistryInterface;

    /**
     * @param TemplateRegistryInterface
     */
    public function setTemplateRegistry(TemplateRegistryInterface $templateRegistry): void;
}
  • The TemplateRegistryAwareInterface is not used at all after this change. Is it useful to keep it ?

Changelog

### Fixed
- `AdminInterface` extends `MutableTemplateRegistryAwareInterface` instead of `TemplateRegistryAwareInterface`

@wbloszyk
Copy link
Member

MutableTemplateRegistryAwareInterface and TemplateRegistryAwareInterface are diffrence. They will be used to auto generate template registry, so we should keep both.

First interface should be used in AbstractAdmin.
Second should be used in Pool (in 4.0).

@VincentLanglet VincentLanglet requested a review from a team November 16, 2020 11:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants