Add deprecation for not passing empty boxes option #6593
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
VincentLanglet
force-pushed
the
emptyBoxesOption
branch
2 times, most recently
from
e872a88 to
97be42c
Compare
franmomu
previously approved these changes
Nov 15, 2020
|
An upgrade note is needed for the deprecation. |
VincentLanglet
force-pushed
the
emptyBoxesOption
branch
from
97be42c to
c60bd6c
Compare
Done |
greg0ire
reviewed
Nov 15, 2020
VincentLanglet
force-pushed
the
emptyBoxesOption
branch
2 times, most recently
from
a826411 to
9f90714
Compare
VincentLanglet
force-pushed
the
emptyBoxesOption
branch
from
9f90714 to
90ba682
Compare
franmomu
approved these changes
Nov 15, 2020
greg0ire
approved these changes
Nov 15, 2020
|
Thanks @VincentLanglet ! Please refrain from marking conversations you did not started as resolved, it just makes it harder to see your replies, and it should really be the person that opens the conversation that decides if they are fine with what you did or not (you are obviously fine with what you do, or so I hope 😅 ) |
Oh ok, sorry ! No bad intentions ^^' |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Subject
I am targeting this branch, because BC.
Related to #6589
Changelog