-
-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add NOT_EQUAL operator for StringOperatorType #6585
Add NOT_EQUAL operator for StringOperatorType #6585
Conversation
Maybe you should add localization? |
The key already exists, from the equalOperatorType |
Sorry. I didn't notice. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
IMO, we should add an upgrade note with this change.
With what kind of message ? |
I think something like this could work:
|
Then I think the same as sonata-project/SonataDoctrineORMAdminBundle#1196 (comment) New features are not added to the |
I agree with this premise, in cases where the new feature does not affect the previous behavior without an explicit user's intervention (by adding a new argument, a method call, by setting some service configuration, etc.). Even if a new choice in a dropdown could be considered a slight change, I think it is changing the previous behavior (it's adding a new option in an existing dropdown and allowing end users to filter using a new operator). |
ad87301
to
c68cbb1
Compare
Subject
I am targeting this branch, because BC. This is a new feature.
There is contains and not contains operator, but only the equal operator.
Changelog