Update Admin.js - fix edit list field inline mode triggering validation #6569
Conversation
Fix edit inline validation, encoding problems
leoBergerot
changed the title
leoBergerot
changed the title
src/Resources/public/Admin.js
Outdated
| @@ -226,6 +226,10 @@ var Admin = { | |||
| .replaceWith(html); | |||
| }, | |||
| error: function(xhr, statusText, errorThrown) { | |||
| if (xhr.status === 400){ | |||
There was a problem hiding this comment.
Why only for 400 ?
Do you know if we have to JSON.parse for every case ?
If not, I think a comment could help to understand this check.
There was a problem hiding this comment.
Yes indeed JSON.parse is also needed for 405, 404, 403, i will update this in my pull request.
There was a problem hiding this comment.
Is there some case where you don't need JSON.parse ?
If there are not, we can just write
error: function(xhr, statusText, errorThrown) {
return JSON.parse(xhr.responseText);
}
If there are, how did you decide (between using JSON.parse) for them and for 400, 403, 404, 405 ?
There was a problem hiding this comment.
No because if is a 500 throwed you don't see it, it's html not Json
There was a problem hiding this comment.
ahhh you are right, in production it's not a problem… i speak in case of dev
| @@ -226,6 +226,10 @@ var Admin = { | |||
| .replaceWith(html); | |||
| }, | |||
| error: function(xhr, statusText, errorThrown) { | |||
| if (xhr.status === 400 || xhr.status === 403 || xhr.status === 404 || xhr.status === 405){ | |||
There was a problem hiding this comment.
Couldn't we trust the content-type header instead?
There was a problem hiding this comment.
That would be great to have a better check than status code indeed.
There was a problem hiding this comment.
No news from @leoBergerot, do you know how to update the PR in order to use the content-type header @phansys ?
|
Hi @leoBergerot, Do you have some time to update the PR ? You'll also need to rebase 3.x in order to fix the build ;) |
Fix edit list field inline mode triggering validation.
I am targeting this branch, when you edit field inline mode when validation is triggering there is encoding problems.
Before my solution:
After: