Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Avoid conflict with by_reference option #6565

Merged
merged 1 commit into from
Nov 9, 2020
Merged

Avoid conflict with by_reference option #6565

merged 1 commit into from
Nov 9, 2020

Conversation

VincentLanglet
Copy link
Member

@VincentLanglet VincentLanglet commented Nov 3, 2020 •
edited
Loading

Subject

I am targeting this branch, because bug fix.

Related to #6564.

See #6564 (comment)
Then persistence bundle should pass collection_by_reference instead of by_reference.

Changelog

### Added
- Added `collection_by_reference` option for AdminType

### Changed
- `collection_by_reference` is used instead of `by_reference` in AdminType in order to know which call should be used between `ObjectManipulator::addInstance` and `ObjectManipulator::setObject`.

@VincentLanglet VincentLanglet mentioned this pull request Nov 3, 2020
Closed
@VincentLanglet VincentLanglet requested a review from a team November 3, 2020 12:11
phansys
phansys approved these changes Nov 4, 2020
View reviewed changes
tests/Form/Type/AdminTypeTest.php Show resolved Hide resolved
@phansys
Copy link
Member

phansys commented Nov 4, 2020

BTW, if this is considered a bugfix, the "Fixed" section should be completed in the PR's description.

@VincentLanglet
Copy link
Member Author

BTW, if this is considered a bugfix, the "Fixed" section should be completed in the PR's description.

The Fix part will be in the persistence bundles, by passing the collection_by_reference value instead of by_reference

@phansys phansys requested a review from a team November 4, 2020 23:02
@VincentLanglet
Copy link
Member Author

@sonata-project/contributors Can i get another approval ? :)

@VincentLanglet VincentLanglet merged commit 470d624 into sonata-project:3.x Nov 9, 2020
@VincentLanglet VincentLanglet deleted the by_reference branch November 9, 2020 19:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@phansys phansys phansys approved these changes

Assignees
No one assigned
Labels
minor
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@VincentLanglet @phansys