Add tests for form layout #6563
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
VincentLanglet
previously approved these changes
Nov 2, 2020
phansys
previously approved these changes
Nov 2, 2020
This adds some tests for the twig blocks defined for forms based on https://github.com/symfony/symfony/blob/e68da40f5649bb0266c74c2e1e4bbf83f9c6bb13/src/Symfony/Component/Form/Tests/AbstractLayoutTest.php#L64 and https://github.com/phiamo/MopaBootstrapBundle/blob/7df89019daed24008d4117217c8cb4df972d2751/Tests/Form/AbstractDivLayoutTest.php
franmomu
force-pushed
the
add_test_form_layout
branch
from
504b6c7 to
3d049ed
Compare
VincentLanglet
approved these changes
Nov 3, 2020
phansys
approved these changes
Nov 3, 2020
|
Thanks @franmomu |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds some tests for the twig blocks defined for forms based on https://github.com/symfony/symfony/blob/e68da40f5649bb0266c74c2e1e4bbf83f9c6bb13/src/Symfony/Component/Form/Tests/AbstractLayoutTest.php#L64 and https://github.com/phiamo/MopaBootstrapBundle/blob/7df89019daed24008d4117217c8cb4df972d2751/Tests/Form/AbstractDivLayoutTest.php
So we can add tests to PRs like #6547 more easily.