Allow usage object properties to get/set instance in ObjectManipulator

[peter-gribanov]

Subject

Now the ObjectManipulator does not work correctly if you pass it a DTO without setters and getters and only with public properties.

https://github.com/sonata-project/SonataAdminBundle/pull/6171/files#r510937030

Not sure if this is related, but i got this exception after a recent update:

RuntimeException: Method PlaylistRelationAdminView::setPlaylist() does not exist.
#22 /vendor/sonata-project/admin-bundle/src/Manipulator/ObjectManipulator.php(106): Sonata\AdminBundle\Manipulator\ObjectManipulator::callSetter
#21 /vendor/sonata-project/admin-bundle/src/Manipulator/ObjectManipulator.php(67): Sonata\AdminBundle\Manipulator\ObjectManipulator::setObject
#20 /vendor/sonata-project/admin-bundle/src/Admin/AbstractAdmin.php(3566): Sonata\AdminBundle\Admin\AbstractAdmin::appendParentObject
#19 /vendor/sonata-project/admin-bundle/src/Admin/AbstractAdmin.php(1375): Sonata\AdminBundle\Admin\AbstractAdmin::getNewInstance
#18 /vendor/sonata-project/admin-bundle/src/Form/Type/AdminType.php(111): Sonata\AdminBundle\Form\Type\AdminType::buildForm
#17 /vendor/symfony/form/ResolvedFormType.php(128): Symfony\Component\Form\ResolvedFormType::buildForm
#16 /vendor/symfony/form/FormFactory.php(80): Symfony\Component\Form\FormFactory::createNamedBuilder
#15 /vendor/symfony/form/FormFactory.php(38): Symfony\Component\Form\FormFactory::createNamed
#14 /vendor/symfony/form/Form.php(866): Symfony\Component\Form\Form::add
#13 /vendor/sonata-project/form-extensions/src/EventListener/ResizeFormListener.php(149): Sonata\Form\EventListener\ResizeFormListener::preSubmit
#12 /vendor/symfony/event-dispatcher/EventDispatcher.php(264): Symfony\Component\EventDispatcher\EventDispatcher::doDispatch
#11 /vendor/symfony/event-dispatcher/EventDispatcher.php(239): Symfony\Component\EventDispatcher\EventDispatcher::callListeners
#10 /vendor/symfony/event-dispatcher/EventDispatcher.php(73): Symfony\Component\EventDispatcher\EventDispatcher::dispatch
#9 /vendor/symfony/event-dispatcher/ImmutableEventDispatcher.php(44): Symfony\Component\EventDispatcher\ImmutableEventDispatcher::dispatch
#8 /vendor/symfony/form/Form.php(558): Symfony\Component\Form\Form::submit
#7 /vendor/symfony/form/Form.php(579): Symfony\Component\Form\Form::submit
#6 /vendor/symfony/form/Extension/HttpFoundation/HttpFoundationRequestHandler.php(109): Symfony\Component\Form\Extension\HttpFoundation\HttpFoundationRequestHandler::handleRequest
#5 /vendor/symfony/form/Form.php(493): Symfony\Component\Form\Form::handleRequest
#4 /vendor/sonata-project/admin-bundle/src/Controller/CRUDController.php(319): Sonata\AdminBundle\Controller\CRUDController::editAction
#3 /vendor/symfony/http-kernel/HttpKernel.php(158): Symfony\Component\HttpKernel\HttpKernel::handleRaw
#2 /vendor/symfony/http-kernel/HttpKernel.php(80): Symfony\Component\HttpKernel\HttpKernel::handle
#1 /vendor/symfony/http-kernel/Kernel.php(201): Symfony\Component\HttpKernel\Kernel::handle
#0 /web/app.php(53): null

class PlaylistRelationAdminView
{
    /**
     * @ORM\Column(name="position", type="integer", nullable=false)
     *
     * @var int
     */
    public int $position = 0;

    /**
     * @ORM\Id
     * @ORM\GeneratedValue(strategy="NONE")
     * @ORM\ManyToOne(targetEntity="PlaylistAdminView", inversedBy="relations")
     * @ORM\JoinColumn(name="playlist_id", referencedColumnName="id", nullable=false)
     */
    public ?PlaylistAdminView $playlist = null;

    /**
     * @ORM\Id
     * @ORM\GeneratedValue(strategy="NONE")
     * @ORM\ManyToOne(targetEntity="Video", inversedBy="admin_video_relations")
     * @ORM\JoinColumn(name="video_id", referencedColumnName="id", nullable=false)
     */
    public ?Video $video = null;
}

Changelog

### Fixed
- Allow usage object properties to get/set instance in ObjectManipulator

[VincentLanglet]

Could you also had tests, to avoid a futur regression :)

[VincentLanglet]

Please take a look @sonata-project/contributors

[VincentLanglet]

@peter-gribanov I just saw that there is no test for the callGetter method. Do you mind adding some ? :)

Will a full test-cover, I think I could merge this with only one review.

[peter-gribanov]

@VincentLanglet test testSetObjectPropertyWithParentAssociation is testing callGetter.

[VincentLanglet]

Thanks @peter-gribanov