Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Util] Add type hints to files in Util directory #6533

Merged
merged 1 commit into from
Oct 26, 2020

Conversation

tambait
Copy link
Contributor

@tambait tambait commented Oct 23, 2020

Subject

This is a follow up of #6404 to add param & return type hints.

Changelog

### Added
- Added parameter and return type hints to files in the Util directory

@tambait tambait force-pushed the util-type-hints branch 3 times, most recently from 8fc32c1 to 51c53f5 Compare October 23, 2020 15:34
@tambait
Copy link
Contributor Author

tambait commented Oct 23, 2020

Currently tests are failing because of #L78. I see in jordisala1991 PR #6366 that second parameter which is causing the issue is removed. Also, on #L72 of jordisala1991 PR AclInterface is replaced for MutableAclInterface etc. Can I assume it's ok to implement those and other changes from his PR into this PR?

@VincentLanglet
Copy link
Member

IMHO:

public function getChildren()
    {
        return new self($this->current());
    }

Is correct

@VincentLanglet
Copy link
Member

And the change of AclInterface to MutableAclInterface is ok.

@VincentLanglet
Copy link
Member

I would assume that all his change are ok. I will still review your full PR anyway ;)

@tambait tambait marked this pull request as ready for review October 23, 2020 17:52
src/Util/AdminObjectAclData.php Outdated Show resolved Hide resolved
src/Util/AdminObjectAclData.php Outdated Show resolved Hide resolved
src/Util/AdminObjectAclData.php Outdated Show resolved Hide resolved
src/Util/AdminObjectAclData.php Outdated Show resolved Hide resolved
src/Util/AdminObjectAclData.php Outdated Show resolved Hide resolved
src/Util/AdminObjectAclData.php Outdated Show resolved Hide resolved
src/Util/AdminObjectAclData.php Outdated Show resolved Hide resolved
src/Util/AdminObjectAclManipulator.php Outdated Show resolved Hide resolved
src/Util/AdminObjectAclManipulator.php Show resolved Hide resolved
src/Util/FormBuilderIterator.php Outdated Show resolved Hide resolved
src/Util/AdminObjectAclData.php Outdated Show resolved Hide resolved
src/Util/AdminObjectAclData.php Outdated Show resolved Hide resolved
src/Util/AdminObjectAclManipulator.php Outdated Show resolved Hide resolved
src/Util/AdminObjectAclManipulator.php Outdated Show resolved Hide resolved
src/Util/AdminObjectAclManipulator.php Show resolved Hide resolved
@tambait tambait force-pushed the util-type-hints branch 2 times, most recently from 1bd833b to cd583a2 Compare October 26, 2020 11:08
src/Util/FormBuilderIterator.php Outdated Show resolved Hide resolved
@VincentLanglet VincentLanglet merged commit a9fc410 into sonata-project:master Oct 26, 2020
@VincentLanglet
Copy link
Member

Thanks

@tambait tambait deleted the util-type-hints branch October 26, 2020 18:23
@franmomu franmomu mentioned this pull request Dec 10, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants