-
-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Util] Add type hints to files in Util directory #6533
Conversation
8fc32c1
to
51c53f5
Compare
Currently tests are failing because of #L78. I see in jordisala1991 PR #6366 that second parameter which is causing the issue is removed. Also, on #L72 of jordisala1991 PR |
IMHO:
Is correct |
And the change of AclInterface to MutableAclInterface is ok. |
I would assume that all his change are ok. I will still review your full PR anyway ;) |
51c53f5
to
1734d67
Compare
1734d67
to
6ba37c5
Compare
1bd833b
to
cd583a2
Compare
cd583a2
to
2837948
Compare
Thanks |
Subject
This is a follow up of #6404 to add param & return type hints.
Changelog