Explicitly cast types in CRUDController::batchAction()

[peter-gribanov]

Subject

This PR corrects several issues at once.

No data.all_elements in tpl

Key "all_elements" for array with keys "idx, action, won" does not exist.

Error in SonataAdminBundle:CRUD:batch_confirmation.html.twig

<div class="box-body">
    {% if data.all_elements %} {# at this line #}
        {{ 'message_batch_all_confirmation'|trans({}, 'SonataAdminBundle') }}
    {% else %}
        {% trans with {'%count%': data.idx|length} from 'SonataAdminBundle' %}message_batch_confirmation{% endtrans %}
    {% endif %}
</div>

The problem is due to the fact that the all_elements is a checkbox and if it is not checked, then it will not be in the HTTP request.

Form Data:

_sonata_csrf_token: rLjGreGh3zUGRjBSjebfU6jFjTuzbBhD0dCrs6RWn_g
idx[]: 441
idx[]: 440
idx[]: 439
idx[]: 438
idx[]: 437
action: approve

Undefined index: all_elements

Notice: Undefined index: all_elements

For the same reason, the all_elements will be absent in the data after confirming the action.

Form Data:

confirmation: ok
data: {"idx":["441","440","439","438","437"],"action":"approve"}
_sonata_csrf_token: rLjGreGh3zUGRjBSjebfU6jFjTuzbBhD0dCrs6RWn_g

TypeError

If you select apply to all elements, the ids is missing from the data.

TypeError: Argument 3 passed to Sonata\AdminBundle\Admin\AbstractAdmin::preBatchAction() must be of the type array, null given, called in /www/vendor/sonata-project/admin-bundle/src/Controller/CRUDController.php on line 517
#5 /vendor/sonata-project/admin-bundle/src/Admin\AbstractAdmin.php(805): Sonata\AdminBundle\Admin\AbstractAdmin::preBatchAction
#4 /vendor/sonata-project/admin-bundle/src/Controller/CRUDController.php(517): Sonata\AdminBundle\Controller\CRUDController::batchAction
#3 /vendor/symfony/http-kernel/HttpKernel.php(158): Symfony\Component\HttpKernel\HttpKernel::handleRaw
#2 /vendor/symfony/http-kernel/HttpKernel.php(80): Symfony\Component\HttpKernel\HttpKernel::handle
#1 /vendor/symfony/http-kernel/Kernel.php(201): Symfony\Component\HttpKernel\Kernel::handle
#0 /web/index.php(53): null

Form Data:

confirmation: ok
data: {"all_elements":"on","action":"approve"}
_sonata_csrf_token: 07f1crI4LnSge9E17Q08bMZb8isUsVkZXqUS5UFsNwM

Changelog

### Fixed
- Explicitly cast types in `CRUDController::batchAction()`

[phansys]

I'm not sure why the legacy group is here. Is there any instruction that will be resolved in the next major about these changes?

[peter-gribanov]

These two tests are copy/paste of CRUDControllerTest::testBatchActionWithConfirmation().

[peter-gribanov]

Any news?

[core23]

CI is stuck. Can you please rebase, so we can merge this

[peter-gribanov]

CI is stuck. Can you please rebase, so we can merge this

@core23 It's done. PR is ready for marge.

[franmomu]

Thanks @peter-gribanov!