Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

change html with a links in no_result_content #6513

Merged
merged 1 commit into from
Oct 21, 2020
Merged

change html with a links in no_result_content #6513

merged 1 commit into from
Oct 21, 2020

Conversation

axzx
Copy link
Contributor

@axzx axzx commented Oct 21, 2020

Subject

I am targeting this branch, because BC.

Changelog

### Changed
- html with a links in no_result_content

The go_to_the_first_page link appears when there are more results.
The button_create link only appears if it is not AJAX.

obraz
obraz

Copy link
Member

@VincentLanglet VincentLanglet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What's your issue @axzx ?

The goal was

  • If there is results, see ONLY the go_to_first_page link.
  • If there is no result, see the create button.

With your change, if there is results, you see the link AND the button.

You should not be able to see the button when there is results.

@axzx
Copy link
Contributor Author

axzx commented Oct 21, 2020

What's your issue @axzx ?

The goal was

* If there is results, see ONLY the `go_to_first_page` link.

* If there is no result, see the create button.

With your change, if there is results, you see the link AND the button.

You should not be able to see the button when there is results.

I improved the html a bit.
You also need to pay attention to the Ajax behavior.
I changed the code so that it was as you wrote.

Copy link
Member

@VincentLanglet VincentLanglet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do you have a screenshot of the new render ?

@VincentLanglet VincentLanglet requested a review from a team October 21, 2020 09:39
Copy link
Member

@wbloszyk wbloszyk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Will be nice to have screen shot before merge.

@axzx
Copy link
Contributor Author

axzx commented Oct 21, 2020

Do you have a screenshot of the new render ?

I completed the description of the PR.
Nothing has changed in appearance.

@wbloszyk wbloszyk merged commit 44285ab into sonata-project:3.x Oct 21, 2020
@wbloszyk
Copy link
Member

Thank you @axzx

@axzx axzx deleted the patch-2 branch October 22, 2020 07:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants