-
-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
change html with a links in no_result_content #6513
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What's your issue @axzx ?
The goal was
- If there is results, see ONLY the
go_to_first_page
link. - If there is no result, see the create button.
With your change, if there is results, you see the link AND the button.
You should not be able to see the button when there is results.
I improved the html a bit. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do you have a screenshot of the new render ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Will be nice to have screen shot before merge.
I completed the description of the PR. |
Thank you @axzx |
Subject
I am targeting this branch, because BC.
Changelog
The
go_to_the_first_page
link appears when there are more results.The
button_create
link only appears if it is not AJAX.