Deprecate Validators::validateEntityName()
#6510
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
phansys
force-pushed
the
validators_entity_name
branch
from
e0177d6 to
cec6297
Compare
VincentLanglet
previously approved these changes
Oct 20, 2020
OskarStark
reviewed
Oct 20, 2020
| @@ -51,6 +55,12 @@ public static function validateUsername($username) | |||
| */ | |||
| public static function validateEntityName($shortcut) | |||
| { | |||
| @trigger_error(sprintf( | |||
There was a problem hiding this comment.
Looks like there is a testcase which needs to be marked with @legacy
phansys
force-pushed
the
validators_entity_name
branch
from
cec6297 to
7ab36c6
Compare
OskarStark
reviewed
Oct 20, 2020
| * NEXT_MAJOR: Remove this test. | ||
| * | ||
| * @group legacy | ||
| * | ||
| * @dataProvider getValidateEntityNamesWithExceptionTests |
There was a problem hiding this comment.
This getValidateEntityNamesWithExceptionTests() needs to be removed as well in the next major
OskarStark
reviewed
Oct 20, 2020
|
|
||
| ### Deprecated `Sonata\AdminBundle\Command\Validators::validateEntityName()` | ||
|
|
||
| In version 3.77, the shortcut notation for model class names (`AppBundle:User`) |
There was a problem hiding this comment.
Suggested change
| In version 3.77, the shortcut notation for model class names (`AppBundle:User`) | |
| In version 3.x, the shortcut notation for model class names (`AppBundle:User`) |
until released? 🤔
There was a problem hiding this comment.
Version 3.77 is already released.
phansys
force-pushed
the
validators_entity_name
branch
from
7ab36c6 to
c629c0c
Compare
OskarStark
approved these changes
Oct 20, 2020
VincentLanglet
approved these changes
Oct 20, 2020
|
Thanks @phansys |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Subject
Deprecate
Validators::validateEntityName().I am targeting this branch, because this change respects BC.
Changelog