Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Handle item without admin key #6507

Merged
merged 1 commit into from
Oct 19, 2020
Merged

Handle item without admin key #6507

merged 1 commit into from
Oct 19, 2020

Conversation

VincentLanglet
Copy link
Member

Subject

BC

Closes #6505.

Changelog

### Fixed
- Pool support of group without admin

@VincentLanglet VincentLanglet requested a review from a team October 19, 2020 17:00
@VincentLanglet VincentLanglet mentioned this pull request Oct 19, 2020
Closed
@VincentLanglet VincentLanglet requested a review from a team October 19, 2020 17:20
@franmomu
Copy link
Member

A test covering the issue would be nice.

@VincentLanglet
Copy link
Member Author

A test covering the issue would be nice.

Already done, you can look at the $this->getItemArray(), call added.

franmomu
franmomu approved these changes Oct 19, 2020
View reviewed changes
Copy link
Member

@franmomu franmomu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 I didn't see them

@VincentLanglet VincentLanglet merged commit e2b61ae into sonata-project:3.x Oct 19, 2020
@VincentLanglet VincentLanglet deleted the adminKey branch October 19, 2020 18:39
@iAdil
Copy link

iAdil commented Oct 21, 2020

When you will merge these changes with master branch? The latest version 3.77 still doesn't work.

@phansys
Copy link
Member

phansys commented Oct 21, 2020

When you will merge these changes with master branch? The latest version 3.77 still doesn't work.

The master branch tracks the next major version (4.x). This fix will be present in the next stable release (3.x).

@VincentLanglet
Copy link
Member Author

When you will merge these changes with master branch? The latest version 3.77 still doesn't work.

We gonna make a new release today

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jordisala1991 jordisala1991 jordisala1991 approved these changes

@franmomu franmomu franmomu approved these changes

Assignees
No one assigned
Labels
patch
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

BC Break in 3.77 when declaring groups in dashboard without admin
5 participants
@VincentLanglet @franmomu @iAdil @phansys @jordisala1991