Solve problem with unset batch checkbox`s after back via browser history

[kirya-dev]

Subject

I am targeting this branch, because would like make better sonata-admin.

Closes #6430.

Changelog

### Fixed
- Solve problem with unset batch checkbox`s after back via browser history

[VincentLanglet]

Can you confirm that you tried it on your project and it worked ?

[kirya-dev]

Can you confirm that you tried it on your project and it worked ?

Of course. Checked this in google chrome 85.

[core23]

I don't understand how this could have an inpact to this bug, but it won't break anything.

[VincentLanglet]

I don't understand how this could have an inpact to this bug, but it won't break anything.

https://stackoverflow.com/questions/37933043/reset-checkbox-checked-state-go-back-from-history

[franmomu]

I remember struggling with iCheck some time ago. In this case looks more like an iCheck issue, maybe we should make some call to update the iCheck checkboxes after loading the page.

[kirya-dev]

I remember struggling with iCheck some time ago. In this case looks more like an iCheck issue, maybe we should make some call to update the iCheck checkboxes after loading the page.

What is expected result? Checkboxes are show checked or not?

[franmomu]

Ok! I thought we wanted to check the previously selected boxes.

Can you please also change it in

SonataAdminBundle/src/Resources/views/CRUD/list_outer_rows_mosaic.html.twig

Line 61 in d621ca4

<input type="checkbox" name="idx[]" value="{{ admin.id(object) }}">

[VincentLanglet]

Seems like you totally change your strategy to fix the issue ?
Previously you added autocomplete=false, can you explain the new strategy ?

[kirya-dev]

Seems like you totally change your strategy to fix the issue ?

Yes. @core23 says that want to see previously checked inputs.

[VincentLanglet]

Seems like you totally change your strategy to fix the issue ?

Yes. @core23 says that want to see previously checked inputs.

Ok, I think that's a good idea indead.

WDYT about adding a comment to explain this, something like

// In case some checkbox are already checked (for instance after a back via browser history), update iCheck checkboxes
if (subject === window.document)
...

[VincentLanglet]

Thanks @kirya-dev