Deprecate DatagridManagerInterface #6458
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Yeah, as I said, I don't think this should be in ModelManagerInterface. |
|
Could you please rebase your PR and fix merge conflicts? |
VincentLanglet
force-pushed
the
deprecateDatagridManagerInterface
branch
from
d208a23 to
6864e7a
Compare
VincentLanglet
force-pushed
the
deprecateDatagridManagerInterface
branch
from
6864e7a to
19aa28a
Compare
|
This is ready to be reviewed @sonata-project/contributors :) |
wbloszyk
previously approved these changes
Oct 20, 2020
|
Could you please rebase your PR and fix merge conflicts? |
franmomu
reviewed
Oct 22, 2020
VincentLanglet
force-pushed
the
deprecateDatagridManagerInterface
branch
from
19aa28a to
8885b94
Compare
phansys
requested changes
Oct 31, 2020
Please summarize this in the commit message body. |
The modelManager provided by persistence bundle will be final in next release. Asking someone to rewrite all the method of the model manager, just to change the default sort values or default per page options does not make sens then. We should promote the AbstractAdmin method override, or one day implement a service specific to this configuration.
VincentLanglet
force-pushed
the
deprecateDatagridManagerInterface
branch
from
8885b94 to
4dcde56
Compare
phansys
approved these changes
Oct 31, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Subject
Related to sonata-project/SonataDoctrineORMAdminBundle#1144 (comment)
I am targeting this branch, because BC.
Imho, this does not need to be modelManager-dependant.
WDYT ?
Changelog