Remove large and unneeded resources #6437
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
VincentLanglet
previously approved these changes
Oct 1, 2020
core23
previously approved these changes
Oct 2, 2020
|
Those assets are handled by bower, so if someone updates packages they will appear again |
I'm not sure we're doing that often |
|
I could add a .gitignore to the SonataCoreBundle directory excluding these files so they will never be committed again. |
I like this idea, WDYT @jordisala1991 ? |
Also add a .gitignore file to prevent these files from being added again
|
I've added the .gitignore file. |
VincentLanglet
approved these changes
Oct 2, 2020
jordisala1991
approved these changes
Oct 4, 2020
|
Thank you @jorrit |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Subject
I am trying to optimize the size of my Docker container and a quick review using WinDirStat gave some surprising large files in src/Resources/private/SonataCoreBundleAssets/vendor:
These files are copied to public on
assets:installso they count twice if sym/hardlinking is not available. I think that these files are unnecessary under any circumstance and can be removed without breaking the backwards compatibility promise. Many more files could be removed, but the ones above are the largest by a wide margin.I am targeting this branch, because no user should depend on these files.
Changelog