Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add type hints to data transformers #6377

Merged
merged 3 commits into from
Sep 13, 2020
Merged

Add type hints to data transformers #6377

merged 3 commits into from
Sep 13, 2020

Conversation

core23
Copy link
Member

@core23 core23 commented Sep 5, 2020 •
edited
Loading

Subject

I am targeting this branch, because this is BC.

Changelog

### Added
- Add type hints to data transformers
- Add type hints to util classes

### Fixed
- Allow null transformation in ModelsToArrayTransformer

@core23 core23 added the patch label Sep 7, 2020
@core23 core23 marked this pull request as ready for review September 7, 2020 17:22
@core23
Copy link
Member Author

core23 commented Sep 7, 2020 •
edited
Loading

Backported type hints from #6366

Type coverage: 86.6600%

@jordisala1991
Copy link
Member

I dont recommend backporting from an unfinished PR 😅.

@core23
Copy link
Member Author

core23 commented Sep 8, 2020

I dont recommend backporting from an unfinished PR 😅.

I did not only backport the hints, I merged and verified some of your changes.

@jordisala1991 jordisala1991 merged commit 98677e1 into sonata-project:3.x Sep 13, 2020
@jordisala1991
Copy link
Member

Thank you @core23

@core23 core23 deleted the phpdoc-2 branch September 14, 2020 08:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@VincentLanglet VincentLanglet VincentLanglet approved these changes

@jordisala1991 jordisala1991 jordisala1991 approved these changes

Assignees
No one assigned
Labels
patch
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@core23 @jordisala1991 @VincentLanglet