Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix admin label translation domain #6372

Merged
merged 1 commit into from
Sep 8, 2020
Merged

Fix admin label translation domain #6372

merged 1 commit into from
Sep 8, 2020

Conversation

VincentLanglet
Copy link
Member

@VincentLanglet VincentLanglet commented Sep 4, 2020 •
edited
Loading

Subject

I am targeting this branch, because bug fix.

Changelog

### Fixed
- The default `group` now correctly use the admin translation domain when using the admin label.

@VincentLanglet VincentLanglet marked this pull request as ready for review September 8, 2020 09:15
@VincentLanglet VincentLanglet requested a review from a team September 8, 2020 09:15
@VincentLanglet VincentLanglet requested a review from a team September 8, 2020 20:01
@jordisala1991 jordisala1991 merged commit c2e970b into sonata-project:3.x Sep 8, 2020
@jordisala1991
Copy link
Member

Thank you @VincentLanglet

@VincentLanglet VincentLanglet deleted the fixTranslationDomain branch March 27, 2021 22:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@core23 core23 core23 approved these changes

@jordisala1991 jordisala1991 jordisala1991 approved these changes

Assignees
No one assigned
Labels
patch
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@VincentLanglet @jordisala1991 @core23