Allow symfony config, dependency-injection and routing 5.1 #6369
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
greg0ire
reviewed
Sep 3, 2020
Looks fine as is 👍 (it's internal anyway) |
Symfony/config 5.1 introduces a deprecation notice when calling setDeprecation() with less than 3 args. An internal helper class has been added as a BC layer.
franmomu
force-pushed
the
allow_symfony_config_di
branch
from
8aa6bba to
2ff63c5
Compare
greg0ire
approved these changes
Sep 3, 2020
jordisala1991
approved these changes
Sep 3, 2020
|
Thank you @franmomu |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Symfony/config 5.1 introduces a deprecation notice when calling setDeprecation() with less than 3 args. An internal helper class has been added as a BC layer, any suggestion about the name is welcome. The implementation is based on the DoctrineBundle one.
Even if these deprecations will be removed in 4.x, we still need the BC layer for future deprecations.
Subject
I am targeting this branch, because these changes are BC.
Changelog