Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update docs #6336

Merged
merged 1 commit into from
Aug 28, 2020
Merged

Update docs #6336

merged 1 commit into from
Aug 28, 2020

Conversation

kirya-dev
Copy link
Contributor

docs/reference/form_types.rst Outdated Show resolved Hide resolved
docs/reference/form_types.rst Outdated Show resolved Hide resolved
docs/reference/form_types.rst Outdated Show resolved Hide resolved
docs/reference/form_types.rst Outdated Show resolved Hide resolved
@phansys phansys added the docs label Aug 28, 2020
@kirya-dev kirya-dev requested a review from phansys August 28, 2020 05:37
phansys
phansys previously approved these changes Aug 28, 2020
@jordisala1991
Copy link
Member

You need to rebase

VincentLanglet
VincentLanglet previously approved these changes Aug 28, 2020
docs/reference/form_types.rst Outdated Show resolved Hide resolved
docs/reference/form_types.rst Outdated Show resolved Hide resolved
docs/reference/form_types.rst Outdated Show resolved Hide resolved
@kirya-dev kirya-dev dismissed stale reviews from VincentLanglet and phansys via 4c2725d August 28, 2020 19:50
@codecov-commenter
Copy link

codecov-commenter commented Aug 28, 2020

Codecov Report

Merging #6336 into 3.x will increase coverage by 0.35%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff              @@
##                3.x    #6336      +/-   ##
============================================
+ Coverage     77.23%   77.59%   +0.35%     
+ Complexity     2618     2600      -18     
============================================
  Files           140      140              
  Lines          7779     7743      -36     
============================================
  Hits           6008     6008              
+ Misses         1771     1735      -36     
Impacted Files Coverage Δ Complexity Δ
src/Form/Type/Filter/DateType.php 0.00% <0.00%> (ø) 5.00% <0.00%> (-1.00%)
src/Form/Type/Filter/NumberType.php 0.00% <0.00%> (ø) 5.00% <0.00%> (-1.00%)
src/Form/Type/Filter/DefaultType.php 0.00% <0.00%> (ø) 4.00% <0.00%> (-1.00%)
src/Form/Type/Filter/DateTimeType.php 0.00% <0.00%> (ø) 5.00% <0.00%> (-1.00%)
src/Form/Type/Filter/DateRangeType.php 0.00% <0.00%> (ø) 5.00% <0.00%> (-1.00%)
...rm/Extension/Field/Type/FormTypeFieldExtension.php 88.00% <0.00%> (+1.72%) 26.00% <0.00%> (-1.00%) ⬆️
src/Form/Type/ModelAutocompleteType.php 55.55% <0.00%> (+2.36%) 7.00% <0.00%> (-1.00%) ⬆️
src/Form/Type/AdminType.php 75.40% <0.00%> (+2.39%) 21.00% <0.00%> (-1.00%) ⬆️
src/Form/Type/ModelType.php 58.69% <0.00%> (+2.44%) 16.00% <0.00%> (-1.00%) ⬆️
src/Form/Type/AclMatrixType.php 26.66% <0.00%> (+3.13%) 7.00% <0.00%> (-1.00%) ⬆️
... and 8 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0740ee1...048cc8f. Read the comment docs.

@greg0ire greg0ire merged commit 0c42eda into sonata-project:3.x Aug 28, 2020
@greg0ire
Copy link
Contributor

Thanks @kirya-dev !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Improve ModelAutocompleteFilter
6 participants