Allow php8 build to pass #6333
Merged
Allow php8 build to pass #6333
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jordisala1991
force-pushed
the
test/test/test
branch
4 times, most recently
from
36e1adb to
64e6467
Compare
Codecov Report
@@ Coverage Diff @@
## 3.x #6333 +/- ##
============================================
- Coverage 77.59% 77.50% -0.10%
- Complexity 2600 2602 +2
============================================
Files 140 142 +2
Lines 7743 7778 +35
============================================
+ Hits 6008 6028 +20
- Misses 1735 1750 +15
Continue to review full report at Codecov.
|
jordisala1991
force-pushed
the
test/test/test
branch
2 times, most recently
from
c52c313 to
aabde6d
Compare
jordisala1991
commented
Aug 27, 2020
|
Could you please rebase your PR and fix merge conflicts? |
jordisala1991
force-pushed
the
test/test/test
branch
4 times, most recently
from
054f9f3 to
fe0cb26
Compare
jordisala1991
force-pushed
the
test/test/test
branch
from
fe0cb26 to
44f3082
Compare
|
The build will pass then dev-kit dispatches files |
jordisala1991
force-pushed
the
test/test/test
branch
from
44f3082 to
b10fe6f
Compare
|
Now its working. |
greg0ire
approved these changes
Aug 29, 2020
VincentLanglet
approved these changes
Aug 29, 2020
|
Thanks @jordisala1991 ! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.