-
-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Avoid to mutate original request on CRUDController::batchAction()
#6321
Conversation
There is a psalm failure non related to this Pr that should be fixed |
I'm not familiarized with psalm, so I don't know if these issues are fixable or if we should add them as allowed failures at |
@jordisala1991, do you have any clue? Otherwise, I'd like to avoid tying this PR to the psalm failure. |
Maybe @vladyslavstartsev can help us. I made #6322 I may understand badly the issue, but I would consider this as a psalm bug. Adding |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Have you check if everything works as expected?
Yes, at least with |
Thank you @phansys |
Subject
Avoid to mutate original request on
CRUDController::batchAction()
.I am targeting this branch, because this change respects BC.
Follow up of #6271.
Changelog